summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2014-09-30 22:12:05 -0700
committerDavid S. Miller <davem@davemloft.net>2014-10-01 13:44:05 -0400
commit2c804d0f8fc7799981d9fdd8c88653541b28c1a7 (patch)
tree595446444860fdf7c4e1fe200b218280b10f117c
parenteb51bbaf8dedf142a54a7ff58514a29b40d515bb (diff)
downloadop-kernel-dev-2c804d0f8fc7799981d9fdd8c88653541b28c1a7.zip
op-kernel-dev-2c804d0f8fc7799981d9fdd8c88653541b28c1a7.tar.gz
ipv4: mentions skb_gro_postpull_rcsum() in inet_gro_receive()
Proper CHECKSUM_COMPLETE support needs to adjust skb->csum when we remove one header. Its done using skb_gro_postpull_rcsum() In the case of IPv4, we know that the adjustment is not really needed, because the checksum over IPv4 header is 0. Lets add a comment to ease code comprehension and avoid copy/paste errors. Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/af_inet.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 28e589c..92db7a6 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1369,6 +1369,9 @@ static struct sk_buff **inet_gro_receive(struct sk_buff **head,
* immediately following this IP hdr.
*/
+ /* Note : No need to call skb_gro_postpull_rcsum() here,
+ * as we already checked checksum over ipv4 header was 0
+ */
skb_gro_pull(skb, sizeof(*iph));
skb_set_transport_header(skb, skb_gro_offset(skb));
OpenPOWER on IntegriCloud