diff options
| author | Viresh Kumar <viresh.kumar@linaro.org> | 2014-11-27 08:54:07 +0530 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2014-11-29 23:53:20 +0100 |
| commit | b4037aaa584bd914bbf578f5ceb2d9884fa7ddb6 (patch) | |
| tree | 43ce804178e162d5d57922194483adaacc79a76b | |
| parent | 129eec55df6ab1b5ecdd89fd7db7a2cd103200b5 (diff) | |
| download | op-kernel-dev-b4037aaa584bd914bbf578f5ceb2d9884fa7ddb6.zip op-kernel-dev-b4037aaa584bd914bbf578f5ceb2d9884fa7ddb6.tar.gz | |
PM / OPP replace kfree_rcu() with call_srcu() in opp_set_availability()
This existed before we introduced call_srcu() in opp layer to synchronize with
srcu_notifier_call_chain() while removing OPPs. And is a potential bug which
wasn't noticed earlier.
Let fix it as well by using the right API to free OPP.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/base/power/opp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 977474a..2d195f3 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -641,7 +641,7 @@ static int opp_set_availability(struct device *dev, unsigned long freq, list_replace_rcu(&opp->node, &new_opp->node); mutex_unlock(&dev_opp_list_lock); - kfree_rcu(opp, rcu_head); + call_srcu(&dev_opp->srcu_head.srcu, &opp->rcu_head, kfree_opp_rcu); /* Notify the change of the OPP availability */ if (availability_req) |
