summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean-Francois Moine <moinejf@free.fr>2008-09-03 16:48:14 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2008-09-03 18:36:59 -0300
commitf9b4a377dc6601a3299171c7b24c2c5189c0c10b (patch)
treeefc3414238f8faab6f33a91bd19ec3462882bb5a
parent6a709749228c5f76f128c69c16f39a52d639bd96 (diff)
downloadop-kernel-dev-f9b4a377dc6601a3299171c7b24c2c5189c0c10b.zip
op-kernel-dev-f9b4a377dc6601a3299171c7b24c2c5189c0c10b.tar.gz
V4L/DVB (8719): gspca: Have VIDIOC_QUERYCTRL more compliant to the spec.
- return -EINVAL when control not supported. - start the private controls at V4L2_CID_PRIVATE_BASE. Signed-off-by: Jean-Francois Moine <moinejf@free.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/video/gspca/gspca.c5
-rw-r--r--drivers/media/video/gspca/t613.c2
2 files changed, 1 insertions, 6 deletions
diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index 2f7bf26..061e191 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -884,11 +884,6 @@ static int vidioc_queryctrl(struct file *file, void *priv,
return 0;
}
}
- if (id >= V4L2_CID_BASE
- && id <= V4L2_CID_LASTP1) {
- q_ctrl->flags |= V4L2_CTRL_FLAG_DISABLED;
- return 0;
- }
return -EINVAL;
}
diff --git a/drivers/media/video/gspca/t613.c b/drivers/media/video/gspca/t613.c
index 357a2ed..962c1df 100644
--- a/drivers/media/video/gspca/t613.c
+++ b/drivers/media/video/gspca/t613.c
@@ -30,7 +30,7 @@
#define MAX_GAMMA 0x10 /* 0 to 15 */
-#define V4L2_CID_EFFECTS (V4L2_CID_PRIVATE_BASE + 3)
+#define V4L2_CID_EFFECTS (V4L2_CID_PRIVATE_BASE + 0)
MODULE_AUTHOR("Leandro Costantino <le_costantino@pixartargentina.com.ar>");
MODULE_DESCRIPTION("GSPCA/T613 (JPEG Compliance) USB Camera Driver");
OpenPOWER on IntegriCloud