diff options
| author | Samir Bellabes <sam@synack.fr> | 2010-01-07 22:10:56 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-01-13 20:37:45 -0800 |
| commit | e1d5a010729a7a495a8a8de85727f3f0d62f06a0 (patch) | |
| tree | f1f5b01429ddf5ce7e023088f7ac705bed639db0 | |
| parent | 37fce430dd66a6251bde6ef0004a1da69b26c028 (diff) | |
| download | op-kernel-dev-e1d5a010729a7a495a8a8de85727f3f0d62f06a0.zip op-kernel-dev-e1d5a010729a7a495a8a8de85727f3f0d62f06a0.tar.gz | |
genetlink: optimize ctrl_dumpfamily()
there is a unnecessary test which can be replaced by a good initialization in
the 'for' statement
Noticed by Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Samir Bellabes <sam@synack.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/netlink/genetlink.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index d07ecda..a4b6e14 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -681,9 +681,7 @@ static int ctrl_dumpfamily(struct sk_buff *skb, struct netlink_callback *cb) int chains_to_skip = cb->args[0]; int fams_to_skip = cb->args[1]; - for (i = 0; i < GENL_FAM_TAB_SIZE; i++) { - if (i < chains_to_skip) - continue; + for (i = chains_to_skip; i < GENL_FAM_TAB_SIZE; i++) { n = 0; list_for_each_entry(rt, genl_family_chain(i), family_list) { if (!rt->netnsok && !net_eq(net, &init_net)) |
