summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoland McGrath <roland@redhat.com>2009-02-27 19:03:24 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2009-03-02 15:41:30 -0800
commitccbe495caa5e604b04d5a31d7459a6f6a76a756c (patch)
tree9fea231e87d57869e4f6ecbbdb0cbd4a51bb6873
parent778ef1e6cbb049c9bcbf405936ee6f2b6e451892 (diff)
downloadop-kernel-dev-ccbe495caa5e604b04d5a31d7459a6f6a76a756c.zip
op-kernel-dev-ccbe495caa5e604b04d5a31d7459a6f6a76a756c.tar.gz
x86-64: syscall-audit: fix 32/64 syscall hole
On x86-64, a 32-bit process (TIF_IA32) can switch to 64-bit mode with ljmp, and then use the "syscall" instruction to make a 64-bit system call. A 64-bit process make a 32-bit system call with int $0x80. In both these cases, audit_syscall_entry() will use the wrong system call number table and the wrong system call argument registers. This could be used to circumvent a syscall audit configuration that filters based on the syscall numbers or argument details. Signed-off-by: Roland McGrath <roland@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--arch/x86/kernel/ptrace.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index 5a4c23d..06ca07f 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -1388,7 +1388,7 @@ void send_sigtrap(struct task_struct *tsk, struct pt_regs *regs,
#ifdef CONFIG_X86_32
# define IS_IA32 1
#elif defined CONFIG_IA32_EMULATION
-# define IS_IA32 test_thread_flag(TIF_IA32)
+# define IS_IA32 is_compat_task()
#else
# define IS_IA32 0
#endif
OpenPOWER on IntegriCloud