summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVivek Goyal <vgoyal@redhat.com>2010-11-15 19:32:42 +0100
committerJens Axboe <jaxboe@fusionio.com>2010-11-15 19:32:42 +0100
commitc2f6805d470af369a7337801deeecea800dbfe1c (patch)
tree2381b8c512d611869877adfad3d5e0dfe75e668a
parentd69b78ba1deaaa95ffa8dac5a9ca819ce454d52e (diff)
downloadop-kernel-dev-c2f6805d470af369a7337801deeecea800dbfe1c.zip
op-kernel-dev-c2f6805d470af369a7337801deeecea800dbfe1c.tar.gz
blk-throttle: Fix calculation of max number of WRITES to be dispatched
o Currently we try to dispatch more READS and less WRITES (75%, 25%) in one dispatch round. ummy pointed out that there is a bug in max_nr_writes calculation. This patch fixes it. Reported-by: ummy y <yummylln@yahoo.com.cn> Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
-rw-r--r--block/blk-throttle.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 56ad453..004be80 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -645,7 +645,7 @@ static int throtl_dispatch_tg(struct throtl_data *td, struct throtl_grp *tg,
{
unsigned int nr_reads = 0, nr_writes = 0;
unsigned int max_nr_reads = throtl_grp_quantum*3/4;
- unsigned int max_nr_writes = throtl_grp_quantum - nr_reads;
+ unsigned int max_nr_writes = throtl_grp_quantum - max_nr_reads;
struct bio *bio;
/* Try to dispatch 75% READS and 25% WRITES */
OpenPOWER on IntegriCloud