summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXiaochen Wang <wangxiaochen0@gmail.com>2011-03-18 16:29:25 +0800
committerTakashi Iwai <tiwai@suse.de>2011-03-18 15:14:57 +0100
commit977a6ef3c0cb622b572fb8e2e5088dbe09521375 (patch)
tree561b8544ad980f3ab3fd19f7475a304aea1f94bf
parentd351cf4603edb2a5bfa9a48d06c425511c63f2a3 (diff)
downloadop-kernel-dev-977a6ef3c0cb622b572fb8e2e5088dbe09521375.zip
op-kernel-dev-977a6ef3c0cb622b572fb8e2e5088dbe09521375.tar.gz
sound: read i_size with i_size_read()
Convert direct read of inode->i_size to using i_size_read(). i_size_read is guaranteed to return a valid value and its caller does not need to use addtional locking. Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/sound_firmware.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/sound_firmware.c b/sound/sound_firmware.c
index 340a0bc..7e96249 100644
--- a/sound/sound_firmware.c
+++ b/sound/sound_firmware.c
@@ -19,7 +19,7 @@ static int do_mod_firmware_load(const char *fn, char **fp)
printk(KERN_INFO "Unable to load '%s'.\n", fn);
return 0;
}
- l = filp->f_path.dentry->d_inode->i_size;
+ l = i_size_read(filp->f_path.dentry->d_inode);
if (l <= 0 || l > 131072)
{
printk(KERN_INFO "Invalid firmware '%s'\n", fn);
OpenPOWER on IntegriCloud