diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-05-20 14:59:23 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-05-20 14:59:23 -0400 |
| commit | d93515611bbc70c2fe4db232e5feb448ed8e4cc9 (patch) | |
| tree | 7db1c770bd3a7ac1f27a5e9ccc231719ae3aa6c5 | |
| parent | 7196cd6c3d4863000ef88b09f34d6dd75610ec3e (diff) | |
| download | op-kernel-dev-d93515611bbc70c2fe4db232e5feb448ed8e4cc9.zip op-kernel-dev-d93515611bbc70c2fe4db232e5feb448ed8e4cc9.tar.gz | |
macvlan: fix panic if lowerdev in a bond
commit a35e2c1b6d905 (macvlan: use rx_handler_data pointer to store
macvlan_port pointer V2) added a bug in macvlan_port_create()
Steps to reproduce the bug:
# ifenslave bond0 eth0 eth1
# ip link add link eth0 up name eth0#1 type macvlan
->error EBUSY
# ip link add link eth0 up name eth0#1 type macvlan
->panic
Fix: Dont set IFF_MACVLAN_PORT in error case.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/macvlan.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 07bcb80..bbcf80a 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -585,8 +585,8 @@ static int macvlan_port_create(struct net_device *dev) err = netdev_rx_handler_register(dev, macvlan_handle_frame, port); if (err) kfree(port); - - dev->priv_flags |= IFF_MACVLAN_PORT; + else + dev->priv_flags |= IFF_MACVLAN_PORT; return err; } |
