diff options
| author | David S. Miller <davem@davemloft.net> | 2011-04-17 00:07:55 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-04-17 00:07:55 -0700 |
| commit | e60c5e14fbfcaa54f430aad80b38763a403b2158 (patch) | |
| tree | 7fe90c96a38eb0caaa058fd81a3b5b83497ad54c | |
| parent | dd182574d86e22faaaed37db79e3d54e773f29f7 (diff) | |
| download | op-kernel-dev-e60c5e14fbfcaa54f430aad80b38763a403b2158.zip op-kernel-dev-e60c5e14fbfcaa54f430aad80b38763a403b2158.tar.gz | |
atm: he: Fix undefined sequence points.
GCC complains in these queue index operations because we
perform operations of the form:
x = some_operation(++x);
which is undefined. Replace with:
x = some_operation(x + 1);
which is well defined and provides the intended operation.
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/atm/he.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 6cf59bf..9a51df4 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -1801,7 +1801,7 @@ return_host_buffers: next_rbrq_entry: he_dev->rbrq_head = (struct he_rbrq *) ((unsigned long) he_dev->rbrq_base | - RBRQ_MASK(++he_dev->rbrq_head)); + RBRQ_MASK(he_dev->rbrq_head + 1)); } read_unlock(&vcc_sklist_lock); @@ -1884,7 +1884,7 @@ next_tbrq_entry: pci_pool_free(he_dev->tpd_pool, tpd, TPD_ADDR(tpd->status)); he_dev->tbrq_head = (struct he_tbrq *) ((unsigned long) he_dev->tbrq_base | - TBRQ_MASK(++he_dev->tbrq_head)); + TBRQ_MASK(he_dev->tbrq_head + 1)); } if (updated) { |
