summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDeepak Sikri <deepak.sikri@st.com>2012-07-08 21:14:46 +0000
committerDavid S. Miller <davem@davemloft.net>2012-07-09 14:37:52 -0700
commit684901a6df1fb91fc9a2bdb89ffbebb241428d78 (patch)
treedc1d57f154de1fab19a91cd08257d0407a5e416e
parent8e83989106562326bfd6aaf92174fe138efd026b (diff)
downloadop-kernel-dev-684901a6df1fb91fc9a2bdb89ffbebb241428d78.zip
op-kernel-dev-684901a6df1fb91fc9a2bdb89ffbebb241428d78.tar.gz
stmmac: Fix for higher mtu size handling
For the higher mtu sizes requiring the buffer size greater than 8192, the buffers are sent or received using multiple dma descriptors/ same descriptor with option of multi buffer handling. It was observed during tests that the driver was missing on data packets during the normal ping operations if the data buffers being used catered to jumbo frame handling. The memory barrriers are added in between preparation of dma descriptors in the jumbo frame handling path to ensure all instructions before enabling the dma are complete. Signed-off-by: Deepak Sikri <deepak.sikri@st.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/stmicro/stmmac/ring_mode.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/ring_mode.c b/drivers/net/ethernet/stmicro/stmmac/ring_mode.c
index fb8377d..4b785e1 100644
--- a/drivers/net/ethernet/stmicro/stmmac/ring_mode.c
+++ b/drivers/net/ethernet/stmicro/stmmac/ring_mode.c
@@ -51,7 +51,7 @@ static unsigned int stmmac_jumbo_frm(void *p, struct sk_buff *skb, int csum)
desc->des3 = desc->des2 + BUF_SIZE_4KiB;
priv->hw->desc->prepare_tx_desc(desc, 1, bmax,
csum);
-
+ wmb();
entry = (++priv->cur_tx) % txsize;
desc = priv->dma_tx + entry;
@@ -59,6 +59,7 @@ static unsigned int stmmac_jumbo_frm(void *p, struct sk_buff *skb, int csum)
len, DMA_TO_DEVICE);
desc->des3 = desc->des2 + BUF_SIZE_4KiB;
priv->hw->desc->prepare_tx_desc(desc, 0, len, csum);
+ wmb();
priv->hw->desc->set_tx_owner(desc);
priv->tx_skbuff[entry] = NULL;
} else {
OpenPOWER on IntegriCloud