summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArchit Taneja <archit@ti.com>2012-05-08 18:19:15 +0530
committerTomi Valkeinen <tomi.valkeinen@ti.com>2012-05-09 13:44:07 +0300
commit5dd747e8892a63a5d4cc1d2765c0f533a5d74cfd (patch)
tree2b58d6d31773dfee3c69c755baa07e158ddb540a
parentb917fa3961448903f4ee823917194bdf20709fbd (diff)
downloadop-kernel-dev-5dd747e8892a63a5d4cc1d2765c0f533a5d74cfd.zip
op-kernel-dev-5dd747e8892a63a5d4cc1d2765c0f533a5d74cfd.tar.gz
OMAPDSS: APPLY: Don't check manager settings if it is disabled
If a manager is disabled, there is no guarantee at any point in time that all it's parameters are configured. There is always a chance that some more parameters are yet to be configured by a user of DSS, or by DSS itself. However, when the manager is enabled, we can be certain that all the parameters have been configured, as we can't enable a manager with an incomplete configuration. Therefore, if a manager is disabled, don't check for the validity of it's parameters or the parameters of the overlays connected to it. Only check once it is enabled. Add a check in dss_check_settings_low() to achieve the same. Signed-off-by: Archit Taneja <archit@ti.com>
-rw-r--r--drivers/video/omap2/dss/apply.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/video/omap2/dss/apply.c b/drivers/video/omap2/dss/apply.c
index 57686f6..ad349b3 100644
--- a/drivers/video/omap2/dss/apply.c
+++ b/drivers/video/omap2/dss/apply.c
@@ -192,6 +192,9 @@ static int dss_check_settings_low(struct omap_overlay_manager *mgr,
mp = get_mgr_priv(mgr);
+ if (!mp->enabled)
+ return 0;
+
if (applying && mp->user_info_dirty)
mi = &mp->user_info;
else
OpenPOWER on IntegriCloud