summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFlorian Westphal <fwestphal@astaro.com>2010-02-15 18:15:55 +0100
committerPatrick McHardy <kaber@trash.net>2010-02-15 18:15:55 +0100
commit1756de262e41112a8a8927808eb2f03d21fd4786 (patch)
tree5cf74c0b735e6bcaa9b6dbded3ed91f43aaf6072
parentef00f89f1eb7e056aab9dfe068521e6f2320c94a (diff)
downloadop-kernel-dev-1756de262e41112a8a8927808eb2f03d21fd4786.zip
op-kernel-dev-1756de262e41112a8a8927808eb2f03d21fd4786.tar.gz
netfilter: ebtables: abort if next_offset is too small
next_offset must be > 0, otherwise this loops forever. The offset also contains the size of the ebt_entry structure itself, so anything smaller is invalid. Signed-off-by: Florian Westphal <fwestphal@astaro.com> Signed-off-by: Patrick McHardy <kaber@trash.net>
-rw-r--r--net/bridge/netfilter/ebtables.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index bcdf02d..4370e96 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -444,6 +444,8 @@ static int ebt_verify_pointers(const struct ebt_replace *repl,
break;
if (left < e->next_offset)
break;
+ if (e->next_offset < sizeof(struct ebt_entry))
+ return -EINVAL;
offset += e->next_offset;
}
}
OpenPOWER on IntegriCloud