diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2013-04-04 10:35:23 +0200 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2013-04-08 13:30:45 +0200 |
| commit | 1618b2b02a3a0ee7a6863fed4b0d22e697e7e97c (patch) | |
| tree | 2ab057a6879ac407f6e021551d358e43a0f60071 | |
| parent | d37cac98aba4a5c96142eab71785967feb73022f (diff) | |
| download | op-kernel-dev-1618b2b02a3a0ee7a6863fed4b0d22e697e7e97c.zip op-kernel-dev-1618b2b02a3a0ee7a6863fed4b0d22e697e7e97c.tar.gz | |
iwlwifi: print warning on request_module failure
If request_module() failed then we didn't have the correct
opmode module that the driver needs to function, so print
a warning in this case to make it more obvious what could
be wrong. This still won't catch the case where the module
simply doesn't exist because it wasn't compiled though.
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
| -rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-drv.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.c b/drivers/net/wireless/iwlwifi/iwl-drv.c index b98873c..39aad98 100644 --- a/drivers/net/wireless/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/iwlwifi/iwl-drv.c @@ -998,8 +998,13 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context) * else from proceeding if the module fails to load * or hangs loading. */ - if (load_module) - request_module("%s", op->name); + if (load_module) { + err = request_module("%s", op->name); + if (err) + IWL_ERR(drv, + "failed to load module %s (error %d), is dynamic loading enabled?\n", + op->name, err); + } return; try_again: |
