diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2010-10-23 11:04:12 -0400 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2010-10-25 17:58:40 -0400 |
| commit | 7e4fdd0744fcb9f08854c37643bf529c5945cc36 (patch) | |
| tree | 4587d216b75107bc173a66396e5ca6a4d4e1b0ce | |
| parent | a663bdd8c5d18d287f7468470816c9e0e66343c1 (diff) | |
| download | op-kernel-dev-7e4fdd0744fcb9f08854c37643bf529c5945cc36.zip op-kernel-dev-7e4fdd0744fcb9f08854c37643bf529c5945cc36.tar.gz | |
svcrpc: never clear XPT_BUSY on dead xprt
Once an xprt has been deleted, there's no reason to allow it to be
enqueued--at worst, that might cause the xprt to be re-added to some
global list, resulting in later corruption.
Also, note this leaves us with no need for the reference-count
manipulation here.
Reviewed-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
| -rw-r--r-- | net/sunrpc/svc_xprt.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c index bef1e88..1b0673c 100644 --- a/net/sunrpc/svc_xprt.c +++ b/net/sunrpc/svc_xprt.c @@ -936,10 +936,7 @@ void svc_close_xprt(struct svc_xprt *xprt) /* someone else will have to effect the close */ return; - svc_xprt_get(xprt); svc_delete_xprt(xprt); - clear_bit(XPT_BUSY, &xprt->xpt_flags); - svc_xprt_put(xprt); } EXPORT_SYMBOL_GPL(svc_close_xprt); |
