diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2008-12-06 16:58:39 -0500 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2008-12-06 16:58:39 -0500 |
| commit | 59e315b4c410b00a9acd0f24a00dbadbe81ce692 (patch) | |
| tree | d19e7b45d98c42c6f94cb5aa292e2efea44244f5 | |
| parent | f99b25897a86fcfff9140396a97261ae65fed872 (diff) | |
| download | op-kernel-dev-59e315b4c410b00a9acd0f24a00dbadbe81ce692.zip op-kernel-dev-59e315b4c410b00a9acd0f24a00dbadbe81ce692.tar.gz | |
ext3/4: Fix loop index in do_split() so it is signed
This fixes a gcc warning but it doesn't appear able to result in a
failure, since the primary way the loop is exited is the first
conditional in the for loop, and at least for a consistent filesystem,
the signed/unsigned should in practice never be exposed.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
| -rw-r--r-- | fs/ext3/namei.c | 4 | ||||
| -rw-r--r-- | fs/ext4/namei.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index 287b304..2c2d700 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c @@ -1161,9 +1161,9 @@ static struct ext3_dir_entry_2 *do_split(handle_t *handle, struct inode *dir, u32 hash2; struct dx_map_entry *map; char *data1 = (*bh)->b_data, *data2; - unsigned split, move, size, i; + unsigned split, move, size; struct ext3_dir_entry_2 *de = NULL, *de2; - int err = 0; + int err = 0, i; bh2 = ext3_append (handle, dir, &newblock, &err); if (!(bh2)) { diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 315858d..84a68ae 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -1171,9 +1171,9 @@ static struct ext4_dir_entry_2 *do_split(handle_t *handle, struct inode *dir, u32 hash2; struct dx_map_entry *map; char *data1 = (*bh)->b_data, *data2; - unsigned split, move, size, i; + unsigned split, move, size; struct ext4_dir_entry_2 *de = NULL, *de2; - int err = 0; + int err = 0, i; bh2 = ext4_append (handle, dir, &newblock, &err); if (!(bh2)) { |
