diff options
| author | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-11-20 12:18:11 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-11-21 10:38:38 +0900 |
| commit | 25ec6bbb63e7eec905d94ccb59cdd54cf22ee618 (patch) | |
| tree | 50ed0ad53c4b4fb2238a2b1de6dedec82558941d | |
| parent | ae6a5d37725853325a2b3460165fbc5613ce2916 (diff) | |
| download | op-kernel-dev-25ec6bbb63e7eec905d94ccb59cdd54cf22ee618.zip op-kernel-dev-25ec6bbb63e7eec905d94ccb59cdd54cf22ee618.tar.gz | |
ASoC: kirkwood-dma: don't ignore other irq causes on error
Ignoring the real cause of the interrupt is not a good idea; this
behaviour has been observed to bring Dove platforms to silently
lockup. Instead, on error fall through to the normal interrupt
processing.
This is especially important on Dove platforms as errors are
handled separately, and allows us to clear down the real cause of
the interrupt.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
| -rw-r--r-- | sound/soc/kirkwood/kirkwood-dma.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c index afe1930..2ba0814 100644 --- a/sound/soc/kirkwood/kirkwood-dma.c +++ b/sound/soc/kirkwood/kirkwood-dma.c @@ -71,7 +71,6 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id) printk(KERN_WARNING "%s: got err interrupt 0x%lx\n", __func__, cause); writel(cause, priv->io + KIRKWOOD_ERR_CAUSE); - return IRQ_HANDLED; } /* we've enabled only bytes interrupts ... */ |
