summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYan Zheng <yanzheng@21cn.com>2005-11-14 21:42:46 -0800
committerDavid S. Miller <davem@davemloft.net>2005-11-14 21:42:46 -0800
commit12da2a435c1e8b9abb780d928ccbf04fc3d860a7 (patch)
treebf04e2ac774febba938035f019f57ca4e81169ee
parent4060994c3e337b40e0f6fa8ce2cc178e021baf3d (diff)
downloadop-kernel-dev-12da2a435c1e8b9abb780d928ccbf04fc3d860a7.zip
op-kernel-dev-12da2a435c1e8b9abb780d928ccbf04fc3d860a7.tar.gz
[IPV6]: small fix for ipv6_dev_get_saddr(...)
The "score.rule++" doesn't make any sense for me. According to codes above, I think it should be "hiscore.rule++;" . Signed-off-by: Yan Zheng<yanzheng@21cn.com> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/addrconf.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index ddcf775..56a09a4 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1045,9 +1045,10 @@ int ipv6_dev_get_saddr(struct net_device *daddr_dev,
}
#endif
/* Rule 8: Use longest matching prefix */
- if (hiscore.rule < 8)
+ if (hiscore.rule < 8) {
hiscore.matchlen = ipv6_addr_diff(&ifa_result->addr, daddr);
- score.rule++;
+ hiscore.rule++;
+ }
score.matchlen = ipv6_addr_diff(&ifa->addr, daddr);
if (score.matchlen > hiscore.matchlen) {
score.rule = 8;
OpenPOWER on IntegriCloud