summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLi Wang <liwang@ubuntukylin.com>2013-11-27 22:28:13 +0800
committerSage Weil <sage@inktank.com>2013-12-13 09:13:28 -0800
commitf36132a75aafd0086aeb0eacf348654138d56b49 (patch)
treee385155978e3e4bfbaf326bb6e96f3924e87dd9e
parent8eb4efb091c8d8f70a0e6822288b043f8691ec51 (diff)
downloadop-kernel-dev-f36132a75aafd0086aeb0eacf348654138d56b49.zip
op-kernel-dev-f36132a75aafd0086aeb0eacf348654138d56b49.tar.gz
ceph: Clean up if error occurred in finish_read()
Clean up if error occurred rather than going through normal process Signed-off-by: Li Wang <liwang@ubuntukylin.com> Signed-off-by: Yunchuan Wen <yunchuanwen@ubuntukylin.com> Signed-off-by: Sage Weil <sage@inktank.com>
-rw-r--r--fs/ceph/addr.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index ec3ba43..c346b84 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -256,6 +256,8 @@ static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg)
for (i = 0; i < num_pages; i++) {
struct page *page = osd_data->pages[i];
+ if (rc < 0)
+ goto unlock;
if (bytes < (int)PAGE_CACHE_SIZE) {
/* zero (remainder of) page */
int s = bytes < 0 ? 0 : bytes;
@@ -266,6 +268,7 @@ static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg)
flush_dcache_page(page);
SetPageUptodate(page);
ceph_readpage_to_fscache(inode, page);
+unlock:
unlock_page(page);
page_cache_release(page);
bytes -= PAGE_CACHE_SIZE;
OpenPOWER on IntegriCloud