diff options
| author | Josef Bacik <jbacik@fb.com> | 2014-02-07 12:21:23 -0500 |
|---|---|---|
| committer | Josef Bacik <jbacik@fb.com> | 2014-03-10 15:15:53 -0400 |
| commit | 29bce2f3997a8dc5195b7a7724362d1e55df7bb2 (patch) | |
| tree | 7a7c02ba24263b07ddb1d0716832ff985a4f74f3 | |
| parent | c581afc8db4e9aaa8af2246bb72c1bf72825014d (diff) | |
| download | op-kernel-dev-29bce2f3997a8dc5195b7a7724362d1e55df7bb2.zip op-kernel-dev-29bce2f3997a8dc5195b7a7724362d1e55df7bb2.tar.gz | |
Btrfs: unlock extent and pages on error in cow_file_range
When I converted the BUG_ON() for the free_space_cache_inode in cow_file_range I
made it so we just return an error instead of unlocking all of our various
stuff. This is a mistake and causes us to hang when we run into this. This
patch fixes this problem. Thanks,
Signed-off-by: Josef Bacik <jbacik@fb.com>
| -rw-r--r-- | fs/btrfs/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index a7e6690..5b892500 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -864,7 +864,8 @@ static noinline int cow_file_range(struct inode *inode, if (btrfs_is_free_space_inode(inode)) { WARN_ON_ONCE(1); - return -EINVAL; + ret = -EINVAL; + goto out_unlock; } num_bytes = ALIGN(end - start + 1, blocksize); |
