diff options
| author | Dave Young <hidave.darkstar@gmail.com> | 2009-02-14 21:23:22 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-03-24 16:38:25 -0700 |
| commit | f48f3febb2cbfd0f2ecee7690835ba745c1034a4 (patch) | |
| tree | 1cb3803049cde40ff3dc528a2120f915e65f0367 | |
| parent | e5779a583ddb9916b37cfbb916dc53ec2eaf0b9b (diff) | |
| download | op-kernel-dev-f48f3febb2cbfd0f2ecee7690835ba745c1034a4.zip op-kernel-dev-f48f3febb2cbfd0f2ecee7690835ba745c1034a4.tar.gz | |
driver-core: do not register a driver with bus_type not registered
If the bus_type is not registerd, driver_register to that bus will cause oops.
I found this bug when test built-in usb serial drivers (ie. aircable driver)
with 'nousb' cmdline params.
In this patch:
1. set the bus->p=NULL when bus_register failed and unregisterd.
2. if bus->p is NULL, driver_register BUG_ON will be triggered.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/base/bus.c | 2 | ||||
| -rw-r--r-- | drivers/base/driver.c | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 8547b78..11463c0 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -932,6 +932,7 @@ bus_uevent_fail: kset_unregister(&bus->p->subsys); kfree(bus->p); out: + bus->p = NULL; return retval; } EXPORT_SYMBOL_GPL(bus_register); @@ -953,6 +954,7 @@ void bus_unregister(struct bus_type *bus) bus_remove_file(bus, &bus_attr_uevent); kset_unregister(&bus->p->subsys); kfree(bus->p); + bus->p = NULL; } EXPORT_SYMBOL_GPL(bus_unregister); diff --git a/drivers/base/driver.c b/drivers/base/driver.c index 1e2bda7..2889ad5 100644 --- a/drivers/base/driver.c +++ b/drivers/base/driver.c @@ -216,6 +216,8 @@ int driver_register(struct device_driver *drv) int ret; struct device_driver *other; + BUG_ON(!drv->bus->p); + if ((drv->bus->probe && drv->probe) || (drv->bus->remove && drv->remove) || (drv->bus->shutdown && drv->shutdown)) |
