summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2008-11-06 17:28:20 +1100
committerNeilBrown <neilb@suse.de>2008-11-06 17:28:20 +1100
commita53a6c85756339f82ff19e001e90cfba2d6299a8 (patch)
tree1c2d2601ad6c75aae1f47313f7df256556161fc7
parentcb3ac42b8af357fdd9ad838234245b39e5bdb7fe (diff)
downloadop-kernel-dev-a53a6c85756339f82ff19e001e90cfba2d6299a8.zip
op-kernel-dev-a53a6c85756339f82ff19e001e90cfba2d6299a8.tar.gz
md: fix bug in raid10 recovery.
Adding a spare to a raid10 doesn't cause recovery to start. This is due to an silly type in commit 6c2fce2ef6b4821c21b5c42c7207cb9cf8c87eda and so is a bug in 2.6.27 and .28-rc. Thanks to Thomas Backlund for bisecting to find this. Cc: Thomas Backlund <tmb@mandriva.org> Cc: stable@kernel.org Signed-off-by: NeilBrown <neilb@suse.de>
-rw-r--r--drivers/md/raid10.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index da5129a..970a96e 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1137,7 +1137,7 @@ static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
if (!enough(conf))
return -EINVAL;
- if (rdev->raid_disk)
+ if (rdev->raid_disk >= 0)
first = last = rdev->raid_disk;
if (rdev->saved_raid_disk >= 0 &&
OpenPOWER on IntegriCloud