summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoland Dreier <roland@purestorage.com>2011-12-06 10:02:09 -0800
committerNicholas Bellinger <nab@linux-iscsi.org>2011-12-14 11:38:28 +0000
commitce136176fea522fc8f4c16dcae7e8ed1d890ca39 (patch)
treefc6258199ef01f584f3e2a46ac16c38117d2dc4a
parentced38c8c00962c9b6c1fcd330572406162d150b9 (diff)
downloadop-kernel-dev-ce136176fea522fc8f4c16dcae7e8ed1d890ca39.zip
op-kernel-dev-ce136176fea522fc8f4c16dcae7e8ed1d890ca39.tar.gz
target: Set response format in INQUIRY response
Current SCSI specs say that the "response format" field in the standard INQUIRY response should be set to 2, and all the real SCSI devices I have do put 2 here. So let's do that too. Signed-off-by: Roland Dreier <roland@purestorage.com> Cc: stable@kernel.org Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
-rw-r--r--drivers/target/target_core_cdb.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c
index 5c60d0a..2f2235e 100644
--- a/drivers/target/target_core_cdb.c
+++ b/drivers/target/target_core_cdb.c
@@ -95,6 +95,18 @@ target_emulate_inquiry_std(struct se_cmd *cmd)
buf[2] = dev->transport->get_device_rev(dev);
/*
+ * NORMACA and HISUP = 0, RESPONSE DATA FORMAT = 2
+ *
+ * SPC4 says:
+ * A RESPONSE DATA FORMAT field set to 2h indicates that the
+ * standard INQUIRY data is in the format defined in this
+ * standard. Response data format values less than 2h are
+ * obsolete. Response data format values greater than 2h are
+ * reserved.
+ */
+ buf[3] = 2;
+
+ /*
* Enable SCCS and TPGS fields for Emulated ALUA
*/
if (dev->se_sub_dev->t10_alua.alua_type == SPC3_ALUA_EMULATED)
OpenPOWER on IntegriCloud