summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2013-09-02 13:54:20 +0530
committerDan Williams <dan.j.williams@intel.com>2013-09-09 10:26:04 -0700
commita577659f42f745b71cbc56c80fb1e801ec7e6348 (patch)
tree9d32260e8644af9fdb0c77b7542510e09b7e2466
parente6a5fa63407bfc5b7b13e850a0a67e4db8c00ce7 (diff)
downloadop-kernel-dev-a577659f42f745b71cbc56c80fb1e801ec7e6348.zip
op-kernel-dev-a577659f42f745b71cbc56c80fb1e801ec7e6348.tar.gz
dma: mv_xor: Fix incorrect error path
Return directly if memory allocation fails. There is no need of dma_free_coherent(). Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Saeed Bishara <saeed@marvell.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r--drivers/dma/mv_xor.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index d332b9e..0ec086d 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -1036,10 +1036,8 @@ mv_xor_channel_add(struct mv_xor_device *xordev,
struct dma_device *dma_dev;
mv_chan = devm_kzalloc(&pdev->dev, sizeof(*mv_chan), GFP_KERNEL);
- if (!mv_chan) {
- ret = -ENOMEM;
- goto err_free_dma;
- }
+ if (!mv_chan)
+ return ERR_PTR(-ENOMEM);
mv_chan->idx = idx;
mv_chan->irq = irq;
OpenPOWER on IntegriCloud