diff options
| author | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-06-24 19:55:22 +0000 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-06-25 11:37:23 -0500 |
| commit | d3a263a8168f78874254ea9da9595cfb0f3e96d7 (patch) | |
| tree | bfbe8c87ff990a9530cc3b3be7b4994705986801 | |
| parent | e3f47cc74bddea8121560026185ede4770170043 (diff) | |
| download | op-kernel-dev-d3a263a8168f78874254ea9da9595cfb0f3e96d7.zip op-kernel-dev-d3a263a8168f78874254ea9da9595cfb0f3e96d7.tar.gz | |
[SCSI] zalon: fix oops on attach failure
I recently discovered on my zalon that if the attachment fails because
of a bus misconfiguration (I scrapped my HVD array, so the card is now
unterminated) then the system oopses. The reason is that if
ncr_attach() returns NULL (signalling failure) that NULL is passed by
the goto failed straight into ncr_detach() which oopses.
The fix is just to return -ENODEV in this case.
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
| -rw-r--r-- | drivers/scsi/zalon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/zalon.c b/drivers/scsi/zalon.c index 97f3158..27e84e4 100644 --- a/drivers/scsi/zalon.c +++ b/drivers/scsi/zalon.c @@ -134,7 +134,7 @@ zalon_probe(struct parisc_device *dev) host = ncr_attach(&zalon7xx_template, unit, &device); if (!host) - goto fail; + return -ENODEV; if (request_irq(dev->irq, ncr53c8xx_intr, IRQF_SHARED, "zalon", host)) { dev_printk(KERN_ERR, &dev->dev, "irq problem with %d, detaching\n ", |
