summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJesper Juhl <jj@chaosbits.net>2013-09-30 21:25:27 +0200
committerDavid S. Miller <davem@davemloft.net>2013-10-02 16:00:59 -0400
commit84557783c5574f436826d88cd1bd035f20a4427f (patch)
treeac6c424c9a8c19864904737aa6d6f63326f03fdb
parent99d3d587b2b4314ccc8ea066cb327dfb523d598e (diff)
downloadop-kernel-dev-84557783c5574f436826d88cd1bd035f20a4427f.zip
op-kernel-dev-84557783c5574f436826d88cd1bd035f20a4427f.tar.gz
isdn: eicon: free pointer after using it in log msg in divas_um_idi_delete_entity()
Not really a problem, but nice IMHO; the Coverity static analyzer complains that we use the pointer 'e' after it has been freed, so move the freeing below the final use, even if that use is just using the value of the pointer and not actually dereferencing it. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/isdn/hardware/eicon/um_idi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hardware/eicon/um_idi.c b/drivers/isdn/hardware/eicon/um_idi.c
index 7cab5c3..e151971 100644
--- a/drivers/isdn/hardware/eicon/um_idi.c
+++ b/drivers/isdn/hardware/eicon/um_idi.c
@@ -288,9 +288,9 @@ int divas_um_idi_delete_entity(int adapter_nr, void *entity)
cleanup_entity(e);
diva_os_free(0, e->os_context);
memset(e, 0x00, sizeof(*e));
- diva_os_free(0, e);
DBG_LOG(("A(%d) remove E:%08x", adapter_nr, e));
+ diva_os_free(0, e);
return (0);
}
OpenPOWER on IntegriCloud