summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAkinobu Mita <akinobu.mita@gmail.com>2006-11-28 12:29:43 -0800
committerLinus Torvalds <torvalds@woody.osdl.org>2006-11-28 17:26:50 -0800
commit3cce4856ff3dfa663b1a168dab48120d70820da6 (patch)
tree8d71aa53cff785eb89acd2499179deaf8bc44ca3
parent967bf623e9f5eecfb056b1ba7e0efd74a21c9c3a (diff)
downloadop-kernel-dev-3cce4856ff3dfa663b1a168dab48120d70820da6.zip
op-kernel-dev-3cce4856ff3dfa663b1a168dab48120d70820da6.tar.gz
[PATCH] fix create_write_pipe() error check
The return value of create_write_pipe()/create_read_pipe() should be checked by IS_ERR(). Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--kernel/kmod.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/kernel/kmod.c b/kernel/kmod.c
index bb4e29d..2b76dee 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -307,14 +307,14 @@ int call_usermodehelper_pipe(char *path, char **argv, char **envp,
return 0;
f = create_write_pipe();
- if (!f)
- return -ENOMEM;
+ if (IS_ERR(f))
+ return PTR_ERR(f);
*filp = f;
f = create_read_pipe(f);
- if (!f) {
+ if (IS_ERR(f)) {
free_write_pipe(*filp);
- return -ENOMEM;
+ return PTR_ERR(f);
}
sub_info.stdin = f;
OpenPOWER on IntegriCloud