summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-08-27 04:11:26 +0300
committerLinus Walleij <linus.walleij@linaro.org>2013-08-28 14:44:25 +0200
commit774e2d981f517e7bfbdfbc4174ef258e8c1ab335 (patch)
treea13b80d7e54a147f09d000a48bec7201f095002d
parentddb6c45fb7a41c9830931fd3f0af57b622cede74 (diff)
downloadop-kernel-dev-774e2d981f517e7bfbdfbc4174ef258e8c1ab335.zip
op-kernel-dev-774e2d981f517e7bfbdfbc4174ef258e8c1ab335.tar.gz
pinctrl: s3c24xx: off by one in s3c24xx_eint_init()
If "irq == NUM_EINT" then it writes one space beyond the end of the eint_data->domains[] array. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/pinctrl/pinctrl-s3c24xx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-s3c24xx.c b/drivers/pinctrl/pinctrl-s3c24xx.c
index 24446da..ad3eaad 100644
--- a/drivers/pinctrl/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/pinctrl-s3c24xx.c
@@ -549,7 +549,7 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d)
irq = bank->eint_offset;
mask = bank->eint_mask;
for (pin = 0; mask; ++pin, mask >>= 1) {
- if (irq > NUM_EINT)
+ if (irq >= NUM_EINT)
break;
if (!(mask & 1))
continue;
OpenPOWER on IntegriCloud