diff options
author | David Ahern <dsahern@gmail.com> | 2011-11-13 10:45:27 -0700 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-11-16 10:02:26 -0200 |
commit | 47fbe53bef3b219a365ebf3eca949d6cd4c5291c (patch) | |
tree | d6403822660bed73283d781ca848fca2d6535ff6 | |
parent | 0e2a5f10fb550835e199a3b56a80ed88232188e9 (diff) | |
download | op-kernel-dev-47fbe53bef3b219a365ebf3eca949d6cd4c5291c.zip op-kernel-dev-47fbe53bef3b219a365ebf3eca949d6cd4c5291c.tar.gz |
perf session: Fix crash with invalid CPU list
commit 5d67be9 added the option to specify a range of CPUs of interest,
but does not catch an invalid CPU list:
$ perf script -c foo
Segmentation fault (core dumped)
Cc: Anton Blanchard <anton@samba.org>
Link: http://lkml.kernel.org/r/1321206327-5881-1-git-send-email-dsahern@gmail.com
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/util/session.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 85c1e6b7..0f4555c 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1333,6 +1333,10 @@ int perf_session__cpu_bitmap(struct perf_session *session, } map = cpu_map__new(cpu_list); + if (map == NULL) { + pr_err("Invalid cpu_list\n"); + return -1; + } for (i = 0; i < map->nr; i++) { int cpu = map->map[i]; |