diff options
| author | Julia Lawall <julia@diku.dk> | 2009-11-12 23:08:36 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2010-02-04 11:55:46 +0100 |
| commit | 7e2a10836c0455cb3ca397f89b8280496148d571 (patch) | |
| tree | 26a00a1581727fb1177e509826bedd727b53a265 | |
| parent | fe9a2302230fa287715a11a3d3aec74eec75a6a4 (diff) | |
| download | op-kernel-dev-7e2a10836c0455cb3ca397f89b8280496148d571.zip op-kernel-dev-7e2a10836c0455cb3ca397f89b8280496148d571.tar.gz | |
fs/qnx4: decrement sizeof size in strncmp
As an identical match is wanted in this case, strcmp can be used instead.
The semantic match that lead to detecting this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression foo;
constant char *abc;
@@
*strncmp(foo, abc, sizeof(abc))
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Anders Larsen <al@alarsen.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | fs/qnx4/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c index ebf3440..277575d 100644 --- a/fs/qnx4/inode.c +++ b/fs/qnx4/inode.c @@ -201,7 +201,8 @@ static const char *qnx4_checkroot(struct super_block *sb) rootdir = (struct qnx4_inode_entry *) (bh->b_data + i * QNX4_DIR_ENTRY_SIZE); if (rootdir->di_fname != NULL) { QNX4DEBUG((KERN_INFO "rootdir entry found : [%s]\n", rootdir->di_fname)); - if (!strncmp(rootdir->di_fname, QNX4_BMNAME, sizeof QNX4_BMNAME)) { + if (!strcmp(rootdir->di_fname, + QNX4_BMNAME)) { found = 1; qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL ); if (!qnx4_sb(sb)->BitMap) { |
