summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikolay Aleksandrov <nikolay@redhat.com>2013-06-12 00:07:01 +0200
committerDavid S. Miller <davem@davemloft.net>2013-06-13 02:33:37 -0700
commitb8fad459f9cc8417b74f71c6c229eef7412163d1 (patch)
tree63b671e93aa984f6803745f8eabe21c1642f9236
parent2dc85bf323515e59e15dfa858d1472bb25cad0fe (diff)
downloadop-kernel-dev-b8fad459f9cc8417b74f71c6c229eef7412163d1.zip
op-kernel-dev-b8fad459f9cc8417b74f71c6c229eef7412163d1.tar.gz
bonding: reset master mac on first enslave failure
If the bond device is supposed to get the first slave's MAC address and the first enslavement fails then we need to reset the master's MAC otherwise it will stay the same as the failed slave device. We do it after err_undo_flags since that is the first place where the MAC can be changed and we check if it should've been the first slave and if the bond's MAC was set to it because that err place is used by multiple locations prior to changing the master's MAC address. Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/bonding/bond_main.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 29b846c..473633a 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1957,6 +1957,10 @@ err_free:
err_undo_flags:
bond_compute_features(bond);
+ /* Enslave of first slave has failed and we need to fix master's mac */
+ if (bond->slave_cnt == 0 &&
+ ether_addr_equal(bond_dev->dev_addr, slave_dev->dev_addr))
+ eth_hw_addr_random(bond_dev);
return res;
}
OpenPOWER on IntegriCloud