diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2007-07-30 11:26:38 -0700 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-07-30 14:25:23 -0700 |
commit | 74c5b597e9c2fc728c61582afdea4971a5c8ed8f (patch) | |
tree | 1441aeb556118c7797f240c6314be2028d2de2f5 | |
parent | f285ea058001ef534f9e53a21aad42c2952bbad5 (diff) | |
download | op-kernel-dev-74c5b597e9c2fc728c61582afdea4971a5c8ed8f.zip op-kernel-dev-74c5b597e9c2fc728c61582afdea4971a5c8ed8f.tar.gz |
modules: better error messages when modules fail to load due to a sysfs problem.
This helps people when debugging problems like the ones that were in the
recent -mm releases.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | kernel/params.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/kernel/params.c b/kernel/params.c index effbaae..4e57732 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -567,7 +567,12 @@ static void __init kernel_param_sysfs_setup(const char *name, kobject_set_name(&mk->kobj, name); kobject_init(&mk->kobj); ret = kobject_add(&mk->kobj); - BUG_ON(ret < 0); + if (ret) { + printk(KERN_ERR "Module '%s' failed to be added to sysfs, " + "error number %d\n", name, ret); + printk(KERN_ERR "The system will be unstable now.\n"); + return; + } param_sysfs_setup(mk, kparam, num_params, name_skip); kobject_uevent(&mk->kobj, KOBJ_ADD); } |