summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMathias Krause <minipli@googlemail.com>2013-09-30 22:04:24 +0200
committerEric Paris <eparis@redhat.com>2013-11-05 11:08:30 -0500
commit64fbff9ae0a0a843365d922e0057fc785f23f0e3 (patch)
treee6744c5150c5a5ec1dd2ad7f198f89478f75976e
parentdb510fc5cd9b9db214d7ec1828662942fac19c8c (diff)
downloadop-kernel-dev-64fbff9ae0a0a843365d922e0057fc785f23f0e3.zip
op-kernel-dev-64fbff9ae0a0a843365d922e0057fc785f23f0e3.tar.gz
audit: fix info leak in AUDIT_GET requests
We leak 4 bytes of kernel stack in response to an AUDIT_GET request as we miss to initialize the mask member of status_set. Fix that. Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Eric Paris <eparis@redhat.com> Cc: stable@vger.kernel.org # v2.6.6+ Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: Richard Guy Briggs <rgb@redhat.com> Signed-off-by: Eric Paris <eparis@redhat.com>
-rw-r--r--kernel/audit.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/audit.c b/kernel/audit.c
index f3f36f5..e0f7767 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -759,6 +759,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
switch (msg_type) {
case AUDIT_GET:
+ status_set.mask = 0;
status_set.enabled = audit_enabled;
status_set.failure = audit_failure;
status_set.pid = audit_pid;
OpenPOWER on IntegriCloud