summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBen Greear <greearb@candelatech.com>2011-07-12 10:27:55 -0700
committerTrond Myklebust <Trond.Myklebust@netapp.com>2011-07-12 13:40:13 -0400
commitec0dd267bf7d08cb30e321e45a75fd40edd7e528 (patch)
tree3bf48630b67c339e968c80965e9696027393c968
parente5012d1f3861d18c7f3814e757c1c3ab3741dbcd (diff)
downloadop-kernel-dev-ec0dd267bf7d08cb30e321e45a75fd40edd7e528.zip
op-kernel-dev-ec0dd267bf7d08cb30e321e45a75fd40edd7e528.tar.gz
SUNRPC: Fix use of static variable in rpcb_getport_async
Because struct rpcbind_args *map was declared static, if two threads entered this method at the same time, the values assigned to map could be sent two two differen tasks. This could cause all sorts of problems, include use-after-free and double-free of memory. Fix this by removing the static declaration so that the map pointer is on the stack. Signed-off-by: Ben Greear <greearb@candelatech.com> Cc: stable@kernel.org Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r--net/sunrpc/rpcb_clnt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index 9a80a92..e45d2fb 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -597,7 +597,7 @@ void rpcb_getport_async(struct rpc_task *task)
u32 bind_version;
struct rpc_xprt *xprt;
struct rpc_clnt *rpcb_clnt;
- static struct rpcbind_args *map;
+ struct rpcbind_args *map;
struct rpc_task *child;
struct sockaddr_storage addr;
struct sockaddr *sap = (struct sockaddr *)&addr;
OpenPOWER on IntegriCloud