summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul E. McKenney <paul.mckenney@linaro.org>2012-10-15 08:24:54 -0700
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2012-10-23 14:54:09 -0700
commit340f588bbaed6cb518aa65e7a330dcc3fff911f8 (patch)
treeae8973ce0bb0aa363f4a9707fb90b7445f381b2a
parent3705b88db0d7cc4a097c32d9e554054103d3f807 (diff)
downloadop-kernel-dev-340f588bbaed6cb518aa65e7a330dcc3fff911f8.zip
op-kernel-dev-340f588bbaed6cb518aa65e7a330dcc3fff911f8.tar.gz
rcu: Fix precedence error in cpu_needs_another_gp()
The fix introduced by a10d206e (rcu: Fix day-one dyntick-idle stall-warning bug) has a C-language precedence error. It turns out that this error is harmless in that the same result is computed for all inputs, but the code is nevertheless a potential source of confusion. This commit therefore introduces parentheses in order to force the execution of the code to reflect the intent. Reported-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
-rw-r--r--kernel/rcutree.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index f9c17c3..effd47a 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -313,7 +313,7 @@ static int
cpu_needs_another_gp(struct rcu_state *rsp, struct rcu_data *rdp)
{
return *rdp->nxttail[RCU_DONE_TAIL +
- ACCESS_ONCE(rsp->completed) != rdp->completed] &&
+ (ACCESS_ONCE(rsp->completed) != rdp->completed)] &&
!rcu_gp_in_progress(rsp);
}
OpenPOWER on IntegriCloud