summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Hunter <adrian.hunter@intel.com>2013-07-04 16:20:23 +0300
committerArnaldo Carvalho de Melo <acme@redhat.com>2013-07-08 17:45:41 -0300
commitb2c34fde048f3c85ef0716a8cdabbe46ac67d1e6 (patch)
tree234d694cf5d645d4c5af97b2f9c4c535817a16bd
parent7cab84e8975cfb8a59ce3e79ce75e5eedd384484 (diff)
downloadop-kernel-dev-b2c34fde048f3c85ef0716a8cdabbe46ac67d1e6.zip
op-kernel-dev-b2c34fde048f3c85ef0716a8cdabbe46ac67d1e6.tar.gz
perf tools: Fix parse_events_terms() segfault on error path
On the error path, 'data.terms' may not have been initialised. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1372944040-32690-5-git-send-email-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/util/parse-events.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 6c8bb0f..d8dcb8d 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -860,7 +860,8 @@ int parse_events_terms(struct list_head *terms, const char *str)
return 0;
}
- parse_events__free_terms(data.terms);
+ if (data.terms)
+ parse_events__free_terms(data.terms);
return ret;
}
OpenPOWER on IntegriCloud