summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2012-07-08 01:37:38 +0000
committerDavid S. Miller <davem@davemloft.net>2012-07-09 15:24:33 -0700
commit1b9faf5e66bae8428a4ccdc1447d5399d1014581 (patch)
tree5b54895de312fcc6ad04a98d38d03dcc815168f0
parent91c68ce2b26319248a32d7baa1226f819d283758 (diff)
downloadop-kernel-dev-1b9faf5e66bae8428a4ccdc1447d5399d1014581.zip
op-kernel-dev-1b9faf5e66bae8428a4ccdc1447d5399d1014581.tar.gz
drivers/isdn/mISDN/stack.c: remove invalid reference to list iterator variable
If list_for_each_entry, etc complete a traversal of the list, the iterator variable ends up pointing to an address at an offset from the list head, and not a meaningful structure. Thus this value should not be used after the end of the iterator. The dereferences are just deleted from the debugging statement. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/isdn/mISDN/stack.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/isdn/mISDN/stack.c b/drivers/isdn/mISDN/stack.c
index 1a0ae44..5f21f629 100644
--- a/drivers/isdn/mISDN/stack.c
+++ b/drivers/isdn/mISDN/stack.c
@@ -135,8 +135,8 @@ send_layer2(struct mISDNstack *st, struct sk_buff *skb)
skb = NULL;
else if (*debug & DEBUG_SEND_ERR)
printk(KERN_DEBUG
- "%s ch%d mgr prim(%x) addr(%x) err %d\n",
- __func__, ch->nr, hh->prim, ch->addr, ret);
+ "%s mgr prim(%x) err %d\n",
+ __func__, hh->prim, ret);
}
out:
mutex_unlock(&st->lmutex);
OpenPOWER on IntegriCloud