summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2009-12-15 16:47:46 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2009-12-16 07:20:13 -0800
commitea58ceb543b45d45b257a86eaf9d60c94e8adcf2 (patch)
treed2c44790f9a79e4d1eab26ff02b6880ab7966120
parent06a7f711246b081afc21fff859f1003f1f2a0fbc (diff)
downloadop-kernel-dev-ea58ceb543b45d45b257a86eaf9d60c94e8adcf2.zip
op-kernel-dev-ea58ceb543b45d45b257a86eaf9d60c94e8adcf2.tar.gz
FS-Cache: Avoid maybe-used-uninitialised warning on variable
Andrew Morton's compiler sees the following warning in FS-Cache: fs/fscache/object-list.c: In function 'fscache_objlist_lookup': fs/fscache/object-list.c:94: warning: 'obj' may be used uninitialized in this function which my compiler doesn't. This is a false positive as obj can only be used in the comparison against minobj if minobj has been set to something other than NULL, but for that to happen, obj has to be first set to something. Deal with this by preclearing obj too. Reported-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/fscache/object-list.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fscache/object-list.c b/fs/fscache/object-list.c
index e590242..3221a0c 100644
--- a/fs/fscache/object-list.c
+++ b/fs/fscache/object-list.c
@@ -91,7 +91,7 @@ EXPORT_SYMBOL(fscache_object_destroy);
*/
static struct fscache_object *fscache_objlist_lookup(loff_t *_pos)
{
- struct fscache_object *pobj, *obj, *minobj = NULL;
+ struct fscache_object *pobj, *obj = NULL, *minobj = NULL;
struct rb_node *p;
unsigned long pos;
OpenPOWER on IntegriCloud