summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars-Peter Clausen <lars@metafoo.de>2013-03-22 14:12:03 +0100
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-03-26 14:14:46 +0000
commit340af748bc4004982a1a11ea2d81a4bffe6eb975 (patch)
tree986405e6bd757b6445cda50ef2c425b301453c22
parent023934b4052b1a955ac8d68c8d4b216d1c55c611 (diff)
downloadop-kernel-dev-340af748bc4004982a1a11ea2d81a4bffe6eb975.zip
op-kernel-dev-340af748bc4004982a1a11ea2d81a4bffe6eb975.tar.gz
ASoC: omap-pcm: No need to wrap snd_dmaengine_pcm_close()
If a PCM driver using the dmaengine PCM helper functions doesn't need to do anything special in its pcm_close callback, snd_dmaengine_pcm_close can be used directly for as the pcm_close callback and there is no need to wrap it in a custom function. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r--sound/soc/omap/omap-pcm.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 1626fb7..6c842c7 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -154,12 +154,6 @@ static int omap_pcm_open(struct snd_pcm_substream *substream)
&dma_data->dma_req);
}
-static int omap_pcm_close(struct snd_pcm_substream *substream)
-{
- snd_dmaengine_pcm_close(substream);
- return 0;
-}
-
static int omap_pcm_mmap(struct snd_pcm_substream *substream,
struct vm_area_struct *vma)
{
@@ -173,7 +167,7 @@ static int omap_pcm_mmap(struct snd_pcm_substream *substream,
static struct snd_pcm_ops omap_pcm_ops = {
.open = omap_pcm_open,
- .close = omap_pcm_close,
+ .close = snd_dmaengine_pcm_close,
.ioctl = snd_pcm_lib_ioctl,
.hw_params = omap_pcm_hw_params,
.hw_free = omap_pcm_hw_free,
OpenPOWER on IntegriCloud