summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOliver Neukum <oliver@neukum.name>2006-11-23 15:40:17 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2006-12-01 14:25:51 -0800
commit10c8211c634f759633ffcdc3b0e2913963b32abc (patch)
treea22758a030a61b6441dfaf0eff934697ff1befb4
parent9aa742ef7c1a7ff8e6df92a93ce3688e99fa66e3 (diff)
downloadop-kernel-dev-10c8211c634f759633ffcdc3b0e2913963b32abc.zip
op-kernel-dev-10c8211c634f759633ffcdc3b0e2913963b32abc.tar.gz
USB: pegasus error path not resetting task's state
there is an error path in the pegasus driver which can leave the task in TASK_UNINTERRUPTIBLE. Depending on when it schedules next, this can be bad. Signed-off-by: Oliver Neukum <oliver@neukum.name> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/net/pegasus.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/net/pegasus.c b/drivers/usb/net/pegasus.c
index 33abbd2..69eb0db 100644
--- a/drivers/usb/net/pegasus.c
+++ b/drivers/usb/net/pegasus.c
@@ -163,6 +163,7 @@ static int get_registers(pegasus_t * pegasus, __u16 indx, __u16 size,
/* using ATOMIC, we'd never wake up if we slept */
if ((ret = usb_submit_urb(pegasus->ctrl_urb, GFP_ATOMIC))) {
+ set_current_state(TASK_RUNNING);
if (ret == -ENODEV)
netif_device_detach(pegasus->net);
if (netif_msg_drv(pegasus))
OpenPOWER on IntegriCloud