summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoerg Roedel <joerg.roedel@amd.com>2008-12-17 16:36:44 +0100
committerJoerg Roedel <joerg.roedel@amd.com>2008-12-17 16:36:44 +0100
commit84df81759590ad16b0024cf46b3423cca76b2e07 (patch)
treead2e21daa3960753dbb3a8c6793d0f6242c063b5
parentcf558d25e5c9f70fa0279c9b7b8b4aed7cae9bd4 (diff)
downloadop-kernel-dev-84df81759590ad16b0024cf46b3423cca76b2e07.zip
op-kernel-dev-84df81759590ad16b0024cf46b3423cca76b2e07.tar.gz
AMD IOMMU: panic if completion wait loop fails
Impact: prevents data corruption after a failed completion wait loop Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
-rw-r--r--arch/x86/kernel/amd_iommu.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index a7b6dec..0a60d60 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -235,8 +235,9 @@ static int iommu_completion_wait(struct amd_iommu *iommu)
status &= ~MMIO_STATUS_COM_WAIT_INT_MASK;
writel(status, iommu->mmio_base + MMIO_STATUS_OFFSET);
- if (unlikely((i == EXIT_LOOP_COUNT) && printk_ratelimit()))
- printk(KERN_WARNING "AMD IOMMU: Completion wait loop failed\n");
+ if (unlikely(i == EXIT_LOOP_COUNT))
+ panic("AMD IOMMU: Completion wait loop failed\n");
+
out:
spin_unlock_irqrestore(&iommu->lock, flags);
OpenPOWER on IntegriCloud