diff options
| author | David Chinner <dgc@sgi.com> | 2008-03-06 13:49:43 +1100 |
|---|---|---|
| committer | Lachlan McIlroy <lachlan@redback.melbourne.sgi.com> | 2008-03-06 16:38:50 +1100 |
| commit | 72772a3b5b158cddcfbbff3ef13b26b03a905158 (patch) | |
| tree | e87303c54834c58dca859c881d693babbf0fce5e | |
| parent | 92d9cd1059f80b9c89dee191ffb88b0872e6a7ae (diff) | |
| download | op-kernel-dev-72772a3b5b158cddcfbbff3ef13b26b03a905158.zip op-kernel-dev-72772a3b5b158cddcfbbff3ef13b26b03a905158.tar.gz | |
[XFS] fix inode leak in xfs_iget_core()
If the radix_tree_preload() fails, we need to destroy the inode we just
read in before trying again. This could leak xfs_vnode structures when
there is memory pressure. Noticed by Christoph Hellwig.
SGI-PV: 977823
SGI-Modid: xfs-linux-melb:xfs-kern:30606a
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
| -rw-r--r-- | fs/xfs/xfs_iget.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c index f01b076..8e09b71 100644 --- a/fs/xfs/xfs_iget.c +++ b/fs/xfs/xfs_iget.c @@ -235,6 +235,7 @@ finish_inode: */ new_icl = kmem_zone_alloc(xfs_icluster_zone, KM_SLEEP); if (radix_tree_preload(GFP_KERNEL)) { + xfs_idestroy(ip); delay(1); goto again; } |
