diff options
| author | Martin Murray <murrayma@citi.umich.edu> | 2006-01-10 13:02:29 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2006-01-10 13:02:29 -0800 |
| commit | ad8e4b75c8a7bed475d72ce09bf5267188621961 (patch) | |
| tree | fe9edd967818a744f87c2d1aa51443bae613fbbf | |
| parent | babbdb1a18d37e57acae7e348ef122f2b905df0a (diff) | |
| download | op-kernel-dev-ad8e4b75c8a7bed475d72ce09bf5267188621961.zip op-kernel-dev-ad8e4b75c8a7bed475d72ce09bf5267188621961.tar.gz | |
[AF_NETLINK]: Fix DoS in netlink_rcv_skb()
From: Martin Murray <murrayma@citi.umich.edu>
Sanity check nlmsg_len during netlink_rcv_skb. An nlmsg_len == 0 can
cause infinite loop in kernel, effectively DoSing machine. Noted by
Matin Murray.
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/netlink/af_netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index a67f1b4..bb50c8a 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1422,7 +1422,7 @@ static int netlink_rcv_skb(struct sk_buff *skb, int (*cb)(struct sk_buff *, while (skb->len >= nlmsg_total_size(0)) { nlh = (struct nlmsghdr *) skb->data; - if (skb->len < nlh->nlmsg_len) + if (nlh->nlmsg_len < NLMSG_HDRLEN || skb->len < nlh->nlmsg_len) return 0; total_len = min(NLMSG_ALIGN(nlh->nlmsg_len), skb->len); |
