diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-11-17 14:39:06 -0800 |
|---|---|---|
| committer | Tony Lindgren <tony@atomide.com> | 2009-11-18 10:34:33 -0800 |
| commit | e7fdc6052e78738ce90e0bdc051f2ddf60e41324 (patch) | |
| tree | adb48c1df8d34eb936923631b94c5d470705882a | |
| parent | d32b20fc7dad87ac95fcc73fca3606c0db85f210 (diff) | |
| download | op-kernel-dev-e7fdc6052e78738ce90e0bdc051f2ddf60e41324.zip op-kernel-dev-e7fdc6052e78738ce90e0bdc051f2ddf60e41324.tar.gz | |
OMAP: cs should be positive in gpmc_cs_free()
The index `cs' is signed, test whether it is negative before we release
gpmc_cs_mem[cs].
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| -rw-r--r-- | arch/arm/mach-omap2/gpmc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index f865756..f3c992e 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -378,7 +378,7 @@ EXPORT_SYMBOL(gpmc_cs_request); void gpmc_cs_free(int cs) { spin_lock(&gpmc_mem_lock); - if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { + if (cs >= GPMC_CS_NUM || cs < 0 || !gpmc_cs_reserved(cs)) { printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs); BUG(); spin_unlock(&gpmc_mem_lock); |
