summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJames Bottomley <James.Bottomley@HansenPartnership.com>2008-02-22 17:07:52 -0600
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2008-02-22 17:23:47 -0600
commit63e4563b9cf77875286312758f61a20f912afbbb (patch)
tree80a7d74e07f6788cb4c9a6eb2443f4590053eea5
parent91b550604480eadcdadc7db8a7d19f496ccad6bd (diff)
downloadop-kernel-dev-63e4563b9cf77875286312758f61a20f912afbbb.zip
op-kernel-dev-63e4563b9cf77875286312758f61a20f912afbbb.tar.gz
[SCSI] libsas: correctly flush the LU queue on error recovery
The current sas_scsi_clear_queue_lu() is wrongly checking for commands which match the pointer to the one passed in. It should be checking for commands which are on the same logical unit as the one passed in. Fix this by checking target pointer and LUN for equality. Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
-rw-r--r--drivers/scsi/libsas/sas_scsi_host.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
index 9c96d1b..704ea06 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -280,7 +280,8 @@ static void sas_scsi_clear_queue_lu(struct list_head *error_q, struct scsi_cmnd
struct scsi_cmnd *cmd, *n;
list_for_each_entry_safe(cmd, n, error_q, eh_entry) {
- if (cmd == my_cmd)
+ if (cmd->device->sdev_target == my_cmd->device->sdev_target &&
+ cmd->device->lun == my_cmd->device->lun)
sas_eh_finish_cmd(cmd);
}
}
OpenPOWER on IntegriCloud