summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-04-05 14:37:28 -0500
committerEric Van Hensbergen <ericvh@gmail.com>2010-04-05 14:37:28 -0500
commit3dc9fef67f6292692dba181a6d0fd0211bd0a607 (patch)
tree643e6ecbcf8ffe58bdbd19ce2acde43643eeaf2b
parent85a770a8889035625466a4cfb1393cd7d2ffd165 (diff)
downloadop-kernel-dev-3dc9fef67f6292692dba181a6d0fd0211bd0a607.zip
op-kernel-dev-3dc9fef67f6292692dba181a6d0fd0211bd0a607.tar.gz
9p: saving negative to unsigned char
Saving -EINVAL as unsigned char truncates the high bits and changes it into 234 instead of -22. This breaks the test for "if (ret == -EINVAL)" in parse_opts(). Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
-rw-r--r--net/9p/client.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/net/9p/client.c b/net/9p/client.c
index a037a29..20a3319 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -71,9 +71,10 @@ inline int p9_is_proto_dotu(struct p9_client *clnt)
EXPORT_SYMBOL(p9_is_proto_dotu);
/* Interpret mount option for protocol version */
-static unsigned char get_protocol_version(const substring_t *name)
+static int get_protocol_version(const substring_t *name)
{
- unsigned char version = -EINVAL;
+ int version = -EINVAL;
+
if (!strncmp("9p2000", name->from, name->to-name->from)) {
version = p9_proto_legacy;
P9_DPRINTK(P9_DEBUG_9P, "Protocol version: Legacy\n");
OpenPOWER on IntegriCloud