diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2010-06-02 22:04:39 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2010-06-02 22:04:39 -0400 |
| commit | 1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72 (patch) | |
| tree | 471ac26edd4fbdfda5a3b091b9d583d579c882cb | |
| parent | 67a3e12b05e055c0415c556a315a3d3eb637e29e (diff) | |
| download | op-kernel-dev-1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72.zip op-kernel-dev-1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72.tar.gz | |
ext4: Make sure the MOVE_EXT ioctl can't overwrite append-only files
Dan Roseberg has reported a problem with the MOVE_EXT ioctl. If the
donor file is an append-only file, we should not allow the operation
to proceed, lest we end up overwriting the contents of an append-only
file.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
| -rw-r--r-- | fs/ext4/move_extent.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 3a6c92a..52abfa1 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -960,6 +960,9 @@ mext_check_arguments(struct inode *orig_inode, return -EINVAL; } + if (IS_IMMUTABLE(donor_inode) || IS_APPEND(donor_inode)) + return -EPERM; + /* Ext4 move extent does not support swapfile */ if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) { ext4_debug("ext4 move extent: The argument files should " |
