summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRalf Baechle <ralf@linux-mips.org>2006-12-06 20:40:26 -0800
committerLinus Torvalds <torvalds@woody.osdl.org>2006-12-07 08:39:45 -0800
commitccdea2f88b5689f0fd29c3804be43a3acf0311e3 (patch)
tree573e44a4107850e6e8a61c5845c7e60beeecb27a
parente384bd1692bab6a1d9aa40c849ac373a68769de2 (diff)
downloadop-kernel-dev-ccdea2f88b5689f0fd29c3804be43a3acf0311e3.zip
op-kernel-dev-ccdea2f88b5689f0fd29c3804be43a3acf0311e3.tar.gz
[PATCH] futex: remove unneeded barrier
When disassembling a kernel I found around over 90 sync Instructions from mb, rmb and wmb calls in the kernel and only few of those make any sense to me. So here's the first one - I think the wmb() in kernel/futex.c is not needed on uniprocessors so should become an smb_wmb(). Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Acked-by: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--kernel/futex.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/futex.c b/kernel/futex.c
index d60b7f7..a8302a1 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -552,7 +552,7 @@ static void wake_futex(struct futex_q *q)
* at the end of wake_up_all() does not prevent this store from
* moving.
*/
- wmb();
+ smp_wmb();
q->lock_ptr = NULL;
}
OpenPOWER on IntegriCloud