summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-05-28 12:33:15 +0200
committerLen Brown <len.brown@intel.com>2010-06-01 12:04:35 -0400
commite29df91e67428c1a651d18df6ec047fcb30282d3 (patch)
treee8a40c8a37ffcfe36b18a2f4f31d71cf24cade27
parent67a3e12b05e055c0415c556a315a3d3eb637e29e (diff)
downloadop-kernel-dev-e29df91e67428c1a651d18df6ec047fcb30282d3.zip
op-kernel-dev-e29df91e67428c1a651d18df6ec047fcb30282d3.tar.gz
SFI: do not return freed pointer
We never actually use the return value of sfi_sysfs_install_table() but it still seems wrong to return a freed pointer. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r--drivers/sfi/sfi_core.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
index 0051959..ceba593 100644
--- a/drivers/sfi/sfi_core.c
+++ b/drivers/sfi/sfi_core.c
@@ -441,8 +441,10 @@ struct sfi_table_attr __init *sfi_sysfs_install_table(u64 pa)
ret = sysfs_create_bin_file(tables_kobj,
&tbl_attr->attr);
- if (ret)
+ if (ret) {
kfree(tbl_attr);
+ tbl_attr = NULL;
+ }
sfi_unmap_table(th);
return tbl_attr;
OpenPOWER on IntegriCloud