summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2008-05-14 10:21:33 -0700
committerSteve French <sfrench@us.ibm.com>2008-05-14 18:44:35 +0000
commite10f7b551d2a79b113d5ce66b5dc9f3657035445 (patch)
tree38334538d8e38248ada7273f0f48eb404940ab9b
parent77c57ec89682c73785d12d51a6d1f873b292fa42 (diff)
downloadop-kernel-dev-e10f7b551d2a79b113d5ce66b5dc9f3657035445.zip
op-kernel-dev-e10f7b551d2a79b113d5ce66b5dc9f3657035445.tar.gz
clarify return value of cifs_convert_flags()
cifs_convert_flags returns 0x20197 in the default case. It's not immediately evident where that number comes from, so change it to be an or'ed set of flags. The compiler will boil it down anyway. (Thanks to Guenter Kukkukk for clarifying the flags). Signed-off-by: Steve French <sfrench@us.ibm.com>
-rw-r--r--fs/cifs/file.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 31a0a33..8636cec 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -75,7 +75,11 @@ static inline int cifs_convert_flags(unsigned int flags)
return (GENERIC_READ | GENERIC_WRITE);
}
- return 0x20197;
+ return (READ_CONTROL | FILE_WRITE_ATTRIBUTES | FILE_READ_ATTRIBUTES |
+ FILE_WRITE_EA | FILE_APPEND_DATA | FILE_WRITE_DATA |
+ FILE_READ_DATA);
+
+
}
static inline int cifs_get_disposition(unsigned int flags)
OpenPOWER on IntegriCloud