diff options
| author | Roel Kluin <12o3l@tiscali.nl> | 2008-04-23 23:44:03 +0200 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-29 01:56:37 -0400 |
| commit | 770f867991155f9c9e36a845a142f770d55ee67c (patch) | |
| tree | 9c43c3069288a9cc94ceb8fda8e75ee58b01dab9 | |
| parent | 0a0a83107c01a8dba04fa40ddb29ff021d4f8112 (diff) | |
| download | op-kernel-dev-770f867991155f9c9e36a845a142f770d55ee67c.zip op-kernel-dev-770f867991155f9c9e36a845a142f770d55ee67c.tar.gz | |
ARM: am79c961a: platform_get_irq() may return signed unnoticed
dev->irq is unsigned, platform_get_irq() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| -rw-r--r-- | drivers/net/arm/am79c961a.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c index ba6bd03..a637910 100644 --- a/drivers/net/arm/am79c961a.c +++ b/drivers/net/arm/am79c961a.c @@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev) * done by the ether bootp loader. */ dev->base_addr = res->start; - dev->irq = platform_get_irq(pdev, 0); + ret = platform_get_irq(pdev, 0); - ret = -ENODEV; - if (dev->irq < 0) + if (ret < 0) { + ret = -ENODEV; goto nodev; + } + dev->irq = ret; + + ret = -ENODEV; if (!request_region(dev->base_addr, 0x18, dev->name)) goto nodev; |
